Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #348 app.view() is not described in the README #410

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 17, 2020

Summary

This pull request fixes #348 by adding the explanation about app.view handlers on README.

In addition, I wanted to propose having another example of app.action with callback_id patterns. Referring to this table may be helpful to understand the whole.

There is one more task related to this.

  • cherry-pick the commit after merging this and make a PR to @slack/bolt@next branch

Requirements (place an x in each [ ])

@seratch seratch added the docs M-T: Documentation work only label Feb 17, 2020
@seratch seratch self-assigned this Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #410 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files           7        7           
  Lines         525      525           
  Branches      150      150           
=======================================
  Hits          427      427           
  Misses         70       70           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c10928...7989abb. Read the comment docs.

@stevengill stevengill merged commit 30ecca7 into slackapi:master Feb 18, 2020
@seratch seratch deleted the issue-348 branch February 18, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.view() is not described in the README
3 participants