Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ack in ExpressReceiver firing twice. Issue #327 #370

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

stevengill
Copy link
Member

Summary

Issue #327. Thanks @jarrodldavis for the patch!

Requirements (place an x in each [ ])

@stevengill stevengill added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Jan 11, 2020
@stevengill stevengill self-assigned this Jan 11, 2020
@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #370 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage    83.2%   83.03%   -0.17%     
==========================================
  Files           7        7              
  Lines         500      501       +1     
  Branches      146      146              
==========================================
  Hits          416      416              
- Misses         55       56       +1     
  Partials       29       29
Impacted Files Coverage Δ
src/ExpressReceiver.ts 68.57% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0dce7b...6dd53ff. Read the comment docs.

@stevengill stevengill merged commit cc4f098 into slackapi:master Jan 13, 2020
@stevengill stevengill deleted the 327 branch May 22, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants