Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak a sentence in Japanese documentation #363

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Dec 25, 2019

Summary

This pull request improves the quality of Japanese documentation. The current comment seems to be a bit confusing. The new one is much closer to the original sentence: You could also set userToken instead.

Just in case, I've assigned @girliemac (another Japanese speaker in the team) as a reviewer but I may self merge after waiting for her response for a while.

Requirements (place an x in each [ ])

@seratch seratch added the docs M-T: Documentation work only label Dec 25, 2019
@seratch seratch self-assigned this Dec 25, 2019
@codecov
Copy link

codecov bot commented Dec 25, 2019

Codecov Report

Merging #363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #363   +/-   ##
=====================================
  Coverage      73%    73%           
=====================================
  Files           7      7           
  Lines         500    500           
  Branches      146    146           
=====================================
  Hits          365    365           
  Misses        103    103           
  Partials       32     32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449b880...c82ffd3. Read the comment docs.

@seratch seratch merged commit 8d20b17 into slackapi:master Jan 3, 2020
@seratch seratch deleted the tweak-ja-docs branch January 3, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants