Fix #324 Responding with 401 status, not 500 for signature verification failures #362
Conversation
seratch
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
- Coverage 83.2% 82.71% -0.49%
==========================================
Files 7 7
Lines 500 509 +9
Branches 146 148 +2
==========================================
+ Hits 416 421 +5
- Misses 55 57 +2
- Partials 29 31 +2
Continue to review full report at Codecov.
|
seratch
force-pushed
the
issue-324
branch
2 times, most recently
from
303c168
to
4fc253b
Compare
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
=========================================
- Coverage 83.46% 83.3% -0.17%
=========================================
Files 7 7
Lines 508 509 +1
Branches 147 147
=========================================
Hits 424 424
- Misses 55 56 +1
Partials 29 29
Continue to review full report at Codecov.
|
| } | ||
| }; | ||
| } | ||
|
|
||
| function logError(logger: Logger, message: string, error: any): void { | ||
| const logMessage = ('code' in error) |
There was a problem hiding this comment.
Currently, all the possible error values have code but this is testing the existence just in case.
…rification failures
There was a problem hiding this comment.
LGTM. Logic looks sound. I agree with @aoberoi assessment over at #324 (comment) that in semver land this should be a major, but since the chance of it actually breaking code is so minimal, we should treat it as a minor.
Summary
This pull request fixes #324 - refer to the issue for details.
Requirements (place an
xin each[ ])