chore(deps): bump @slack/web-api from 6.12.1 to 6.13.0 #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
added
semver:minor
dependencies
misscoded
approved these changes
Sep 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2273 +/- ##
==========================================
- Coverage 87.78% 81.59% -6.20%
==========================================
Files 19 19
Lines 1646 1646
Branches 464 464
==========================================
- Hits 1445 1343 -102
Misses 194 194
- Partials 7 109 +102 ☔ View full report in Codecov by Sentry. |
|
@codecov seems to be finding more indirect changes which is causing the coverage to tank in this PR 😭 I think conditionals have to be exercised to be counted as covered now, but I'm wondering if this is a setting we can adjust. Merging on ❌ hurts the soul sometime 🤠 😔 |
|
Although counting against partial coverage does seem more correct... I'll go ahead with this merge and make plans to repay my coverage debts 😓 @misscoded thank you once more for a fast review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps
@slack/web-apifrom6.12.1to6.13.0to include changes released with@slack/[email protected]in code using the latest@slack/bolt🚀Marking it as a
semver:minorto avoid strangeness with cached dependencies and new changes, and will soon follow up with a release if that sounds right!Requirements