Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replacement steps from apps with custom functions #2149

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

lukegalbraithrussell
Copy link
Contributor

@lukegalbraithrussell lukegalbraithrussell commented Jun 25, 2024

Summary

Steps from maps is deprecated. Custom functions is an alternative.

  • Adds custom functions docs. Duplicative with api.slack.com, but shorter and serves a slightly different purpose methinks. Will reassess
  • Rewrote deprecation warning and fixed CSS

ToC

Screenshot 2024-06-25 at 5 13 08 PM

Corrected Deprecation bubble

Screenshot 2024-06-25 at 5 13 16 PM

Requirements

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.00%. Comparing base (044e3c5) to head (c4a8688).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2149   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files          18       18           
  Lines        1539     1539           
  Branches      442      442           
=======================================
  Hits         1262     1262           
  Misses        179      179           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukegalbraithrussell lukegalbraithrussell marked this pull request as ready for review June 26, 2024 00:12
@@ -234,7 +234,7 @@ body {
padding-bottom: 1em;
}

.tutorial .label-deprecated {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these weren't tutorials so weren't showing up here.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions / questions but non-blocking.

docs/_functions/creating.md Outdated Show resolved Hide resolved
docs/_functions/listening.md Outdated Show resolved Hide resolved
docs/_functions/responding.md Outdated Show resolved Hide resolved
@lukegalbraithrussell lukegalbraithrussell merged commit 2a6b3c5 into main Jul 3, 2024
9 checks passed
@lukegalbraithrussell lukegalbraithrussell deleted the docs-custom-functions branch July 3, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants