Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling signature verification #1342

Closed
wants to merge 1 commit into from

Conversation

goldylucks
Copy link

Summary

This enables E2E testing w/o the need of manual signature verification, by doing:

$ DISABLE_SIGNATURE_VERIFICATION=true node path/to/app.js

Happy to add tests once you approve this direction

related issues:

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Adam Goldman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@filmaj
Copy link
Contributor

filmaj commented Feb 28, 2022

I believe ExpressReceiver's signatureVerification boolean set to false achieves this same behaviour.

I will close this PR. If you think I am mistaken, let's please continue the discussion about this potential change in #1339.

@filmaj filmaj closed this Feb 28, 2022
@goldylucks
Copy link
Author

oh wow, I've been trying to get that functionality for the past 2 weeks!

do add it to the documentation for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants