-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing restart logic #203
Conversation
Lets clarify what people are supposed to do in UPGRADING, make a major version bump, and lock the version of slack-ruby-bot to the next version of slack-ruby-client in .gemspec part of this PR. |
@dblock I've addressed the feedback. Please let me know how you'd like to move forward. If my understanding is correct, these changes won't be compatible until we release a new version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need a passing build first. Change the reference to slack-ruby-client HEAD
via Gemfile, get it to 💚
It's finally ready! 🎉😅 |
I'll keep this open for now till we can at least feature complete slack-ruby/slack-ruby-client#223 for other async IO implementations. |
Care to rebase this @RodneyU215 ? I'll merge. |
Summary
#restart!
has been removed fromSlackRubyBot::Server
. It was causing issues with the restart logic that was recently added toslack-ruby-client
.Requirements