Scrolls if cursor not visible after enter/deletion/paste #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +109,19 @@ class Editor | |||
| top: bounds.top - containerBounds.top | |||
| } | |||
|
|
|||
| scrollCursorIntoView: () -> | |||
There was a problem hiding this comment.
Can you move this into selection.coffee and just call scrollIntoView? I'm trying to start grouping API calls into selection, editor, document, etc and only having quill.coffee have passthroughs into the most common ones.
ericmannes
force-pushed
the
cursor-scrolling
branch
3 times, most recently
from
8fb7c0e
to
86984a6
Compare
ericmannes
force-pushed
the
cursor-scrolling
branch
from
86984a6
to
056e338
Compare
|
Thanks! |
jhchen
added a commit
that referenced
this pull request
Aug 19, 2015
Scrolls if cursor not visible after enter/deletion/paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #433. When the user pastes or presses enter/backspace/delete, the browser's default scrolling behavior is prevented. (See src/lib/dom.coffee:142-143.) I wrote a function that scrolls the cursor into view and added it to the enter/deletion/paste event handlers.