Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ Fix TypeScript error #3803

Merged
merged 1 commit into from
Jun 15, 2023
Merged

🏷️ Fix TypeScript error #3803

merged 1 commit into from
Jun 15, 2023

Conversation

alecgibson
Copy link
Contributor

At the moment we try to reassign lines: Blot and leaves: Blot to
lines: {} and leaves: {}.

This change just creates new variables, so that we don't have these compiler errors.

At the moment we try to reassign `lines: Blot` and `leaves: Blot` to
`lines: {}` and `leaves: {}`.

This change just creates new variables, so that we don't have these
compiler errors.
@alecgibson
Copy link
Contributor Author

@luin I'm not entirely sure why tsc currently succeeds. We get a compilation error on our fork, and my IDE agrees even on upstream develop:

Screenshot 2023-06-15 at 11 06 00

@luin luin merged commit afcee5d into slab:develop Jun 15, 2023
@luin
Copy link
Member

luin commented Jun 15, 2023

Thanks! I believe it was due to different tsconfigs.

@alecgibson alecgibson deleted the fix-ts branch June 15, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants