Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar new formatting buttons #106

Closed
piatra opened this issue May 16, 2014 · 5 comments
Closed

Toolbar new formatting buttons #106

piatra opened this issue May 16, 2014 · 5 comments
Labels

Comments

@piatra
Copy link

piatra commented May 16, 2014

Hi,

First of all I would like to say that I really like you project, very useful and easy to use/integrate.

How should I go about adding new formatting buttons to the toolbar. I am interested in adding headings (h1, h2 etc) and the ability to create unordered and ordered lists. I looked through the documentation and saw the Quill.prototype.addFormat call but I had a hard time figuring out how I can extend the editor with it.

Any help would be appreciated. Thanks :)

@jhchen
Copy link
Member

jhchen commented May 16, 2014

Yes we definitely need more documentation in this area. Both these examples would require internal changes to support, since they introduce new tags. Lists and bullets are even tougher since it somewhat breaks some assumptions in Quill (for example require more than one tag to define a format). I was planning on adding this myself soon.

@anseljh
Copy link

anseljh commented May 17, 2014

Hello! Great project, thanks.

I am also in the same boat, wanting to add new formats for things like headings. After looking through the docs and source, it seems the API doesn't currently support this, and we'd have to modify the underlying Quill code—is that correct? Happy to help do this, but I wanted to make sure I understood the current code first.

@vivekdurai
Copy link

@piatra @anseljh I hacked in headings with a few minor changes - take a look at this. @jhchen I know you may have a few things to say about the way I did it so I'm not PRing this one, in the hope that you may release an official commit with header and ol/ul support soon!

@jhchen jhchen added the feature label May 19, 2014
@jhchen
Copy link
Member

jhchen commented May 19, 2014

Thanks for taking a look at this @vivekdurai. I'm working on lists/bullets at the moment but may be able to get to headers afterwards.

@jhchen
Copy link
Member

jhchen commented May 21, 2014

I'm going to break this into two issues one for lists #82 and one for headers #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants