Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo issue #1019

Closed
cutteroid opened this issue Sep 30, 2016 · 1 comment
Closed

Undo issue #1019

cutteroid opened this issue Sep 30, 2016 · 1 comment

Comments

@cutteroid
Copy link

Still having issues with undo.
Likely related to #889 but not sure.

Steps for Reproduction

  1. Visit playground
    (autosave example chosen because it had some text, nothing more)
  2. Select part of content and input some text
  3. Change text format and input some more text (without format changing undo works as intended)
  4. Hit undo several times
  5. Notice changes on each undo.

Expected behavior:
Content correctly restored to initial state

Actual behavior:
Initial content altered. Different browsers generate different results.

Platforms:

Windows, OS X. Latest Chrome, Firefox, Safari.

Version:

1.0.6

undo_bug
P.S. multiple cursors are some kind of gif compression issue.

@benbro
Copy link
Contributor

benbro commented Sep 30, 2016

I can reproduce with the following steps:

  1. Visit http://quilljs.com/playground/
  2. Type: "111 222"
  3. Place the cursor before the first "2"
  4. Press the Bold button and type "aaa "
  5. Press the Bold button and type "bbb "
  6. Click undo several times.

After step 5 we have:
111 aaa bbb 222

After the first undo I'm getting:
111 aaa bbb22222

After the second undo I'm getting:
111 aaa 222
22
22
2

The result after undo depends on the browser.

Firefox 49 on Windows 7
Version: 1.0.6

@jhchen jhchen closed this as completed in 1d1a9aa Oct 2, 2016
tim-mc pushed a commit to tim-mc/quill that referenced this issue Dec 12, 2016
Bug occurs when browser collapses the unwrapped text node from our
cursor with a following text node. This confuses our editor.update delta
optimization for text changes
tim-mc pushed a commit to tim-mc/quill that referenced this issue Dec 12, 2016
Bug occurs when browser collapses the unwrapped text node from our
cursor with a following text node. This confuses our editor.update delta
optimization for text changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants