Make sure blot is attached before calling formatAt

slab · Jul 6, 2023 · 7370a55 · 7370a55
1 parent b65abc1
commit 7370a55
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/blots/scroll.ts b/blots/scroll.ts
@@ -192,8 +192,10 @@ class Scroll extends ScrollBlot {
 
       renderBlocks.forEach(renderBlock => {
         if (renderBlock.type === 'block') {
-          const block = this.createBlock(renderBlock.attributes);
-          this.insertBefore(block, refBlot || undefined);
+          const block = this.createBlock(
+            renderBlock.attributes,
+            refBlot || undefined,
+          );
           insertInlineContents(block, 0, renderBlock.delta);
         } else {
           const blockEmbed = this.create(
@@ -382,7 +384,7 @@ class Scroll extends ScrollBlot {
     return renderBlocks;
   }
 
-  private createBlock(attributes: AttributeMap) {
+  private createBlock(attributes: AttributeMap, refBlot?: Blot) {
     let blotName: string | undefined;
     const formats: AttributeMap = {};
 
@@ -400,6 +402,8 @@ class Scroll extends ScrollBlot {
       blotName ? attributes[blotName] : undefined,
     ) as ParentBlot;
 
+    this.insertBefore(block, refBlot || undefined);
+
     const length = block.length();
     Object.entries(formats).forEach(([key, value]) => {
       block.formatAt(0, length, key, value);