🏷️ Add module DEFAULTS types

slab · Feb 3, 2023 · 24692c3 · 24692c3
1 parent d2f689f
commit 24692c3
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 5 deletions.
diff --git a/modules/clipboard.ts b/modules/clipboard.ts
@@ -71,6 +71,8 @@ interface ClipboardOptions {
 }
 
 class Clipboard extends Module<ClipboardOptions> {
+  static DEFAULTS: ClipboardOptions;
+
   matchers: [Selector, Matcher][];
 
   constructor(quill: Quill, options: Partial<ClipboardOptions>) {

diff --git a/modules/history.ts b/modules/history.ts
@@ -10,6 +10,8 @@ interface HistoryOptions {
 }
 
 class History extends Module<HistoryOptions> {
+  static DEFAULTS: HistoryOptions;
+
   lastRecorded: number;
   ignoreChange: boolean;
   stack: {

diff --git a/modules/keyboard.ts b/modules/keyboard.ts
@@ -58,6 +58,8 @@ interface KeyboardOptions {
 }
 
 class Keyboard extends Module<KeyboardOptions> {
+  static DEFAULTS: KeyboardOptions;
+
   static match(evt: KeyboardEvent, binding) {
     if (
       ['altKey', 'ctrlKey', 'metaKey', 'shiftKey'].some(key => {

diff --git a/modules/syntax.ts b/modules/syntax.ts
@@ -193,6 +193,8 @@ interface SyntaxOptions {
 }
 
 class Syntax extends Module<SyntaxOptions> {
+  static DEFAULTS: SyntaxOptions & { hljs: any };
+
   static register() {
     Quill.register(CodeToken, true);
     // @ts-expect-error

diff --git a/modules/toolbar.ts b/modules/toolbar.ts
@@ -6,13 +6,16 @@ import Module from '../core/module';
 
 const debug = logger('quill:toolbar');
 
-type Handler = () => void;
+type Handler = (value: any) => void;
 
 interface ToolbarProps {
-  container: HTMLElement;
+  container?: HTMLElement;
+  handlers?: Record<string, Handler>;
 }
 
 class Toolbar extends Module<ToolbarProps> {
+  static DEFAULTS: ToolbarProps;
+
   container: HTMLElement;
   controls: [string, HTMLElement][];
   handlers: Record<string, Handler>;
@@ -36,9 +39,7 @@ class Toolbar extends Module<ToolbarProps> {
     this.container.classList.add('ql-toolbar');
     this.controls = [];
     this.handlers = {};
-    // @ts-expect-error
     Object.keys(this.options.handlers).forEach(format => {
-      // @ts-expect-error
       this.addHandler(format, this.options.handlers[format]);
     });
     Array.from(this.container.querySelectorAll('button, select')).forEach(

diff --git a/modules/uploader.ts b/modules/uploader.ts
@@ -10,6 +10,8 @@ interface UploaderOptions {
 }
 
 class Uploader extends Module<UploaderOptions> {
+  static DEFAULTS: UploaderOptions;
+
   constructor(quill: Quill, options: Partial<UploaderOptions>) {
     super(quill, options);
     quill.root.addEventListener('drop', e => {
@@ -61,7 +63,7 @@ Uploader.DEFAULTS = {
     Promise.all(promises).then(images => {
       const update = images.reduce((delta: Delta, image) => {
         return delta.insert({ image });
-      }, new Delta().retain(range.index).delete(range.length));
+      }, new Delta().retain(range.index).delete(range.length)) as Delta;
       this.quill.updateContents(update, Emitter.sources.USER);
       this.quill.setSelection(
         range.index + images.length,