Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ime-fixup #109

Closed
wants to merge 2 commits into from
Closed

Ime-fixup #109

wants to merge 2 commits into from

Conversation

nanot1m
Copy link

@nanot1m nanot1m commented Nov 29, 2021

Fixes slab/quill#1453

It's a backport of the commit 17f6123
for version 2.0

Update:

Outdated (detached) blot updates lead to inconsistency between parchment and real DOM. Reproduces only in Safari.
Example:

// dom structure
div <-- editor root
  p
    a
      strong
        #text

// perform insert operation at the end of the paragraph --> insert(#text, strong)
// resulting DOM structure
div <-- editor root
  p
    strong
      a
        #text
      #text

// after parchment optimisation phase
div <-- editor root
  p
    br

The problem is when updating parchment from mutation records some blots are created with the same DOM node in the registry, so in order to skip the outdated nodes we should take them right from the registry each time.
Video: https://www.loom.com/share/2a6fbc392f4e459da274a034bcaecdb6

nanot1m and others added 2 commits November 29, 2021 13:46
Fixes #1453

It's a backport of the commit 17f6123
for version 2.0
@jhchen jhchen deleted the branch slab:2.0 May 19, 2022 15:19
@jhchen jhchen closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants