Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styling issue where certain characters were cutoff due to not enough line-height #1389

Merged
merged 15 commits into from
Jul 4, 2024
Merged

Fix styling issue where certain characters were cutoff due to not enough line-height #1389

merged 15 commits into from
Jul 4, 2024

Conversation

DanielleRameau
Copy link
Collaborator

@DanielleRameau DanielleRameau commented Jul 3, 2024 •
edited by jpzwarte
Loading

Fixes #1371

@DanielleRameau DanielleRameau linked an issue Jul 3, 2024 that may be closed by this pull request
Certain characters are cutoff in avatar (like y and g) #1371
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 85c0789

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@sl-design-system/avatar Patch
@sl-design-system/bingel-dc Patch
@sl-design-system/bingel-int Patch
@sl-design-system/clickedu Patch
@sl-design-system/editorial-suite Patch
@sl-design-system/itslearning Patch
@sl-design-system/kampus Patch
@sl-design-system/magister Patch
@sl-design-system/max Patch
@sl-design-system/my-digital-book Patch
@sl-design-system/myvanin Patch
@sl-design-system/neon Patch
@sl-design-system/nowa-era Patch
@sl-design-system/sanoma-learning Patch
@sl-design-system/sanoma-utbildning Patch
@sl-design-system/teas Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

🕸 Website preview

You can view a preview here (commit 85c078902c60d11da1351f83e5821eebceafae4d).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

🕸 Storybook preview

You can view a preview here (commit 85c078902c60d11da1351f83e5821eebceafae4d).

@jpzwarte jpzwarte changed the title Fix/1371 line height avatar Fix styling issue where certain characters were cutoff due to not enough line-heightr Jul 4, 2024
@jpzwarte jpzwarte changed the title Fix styling issue where certain characters were cutoff due to not enough line-heightr Fix styling issue where certain characters were cutoff due to not enough line-height Jul 4, 2024
@jpzwarte jpzwarte marked this pull request as ready for review July 4, 2024 08:50
@jpzwarte jpzwarte merged commit f03971b into main Jul 4, 2024
13 of 14 checks passed
@jpzwarte jpzwarte deleted the fix/1371-line-height-avatar branch July 4, 2024 09:02
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-lach anna-lach anna-lach approved these changes

@Diaan Diaan Awaiting requested review from Diaan Diaan is a code owner

@jpzwarte jpzwarte Awaiting requested review from jpzwarte jpzwarte is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certain characters are cutoff in avatar (like y and g)
3 participants
@DanielleRameau @jpzwarte @anna-lach