Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1358 progress bar component #1377

Merged
merged 74 commits into from
Jul 8, 2024
Merged

Feature/1358 progress bar component #1377

merged 74 commits into from
Jul 8, 2024

Conversation

anna-lach
Copy link
Collaborator

No description provided.

anna-lach and others added 23 commits June 24, 2024 16:18
@anna-lach
Progress bar component - initial structure
81c6153
@anna-lach
indeterminate property
abab6e5
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1358-POC-prog…
6985dc3 
…ress-indicator-component
@DanielleRameau
updated color of hint in SL theme
807d2fd
@DanielleRameau
added height token and color tokens progress bar in SL theme
045408f
@DanielleRameau
added progress bar warning colors
dadbdc7
@anna-lach
Some progress bar properties, partially added styling and story changes
2c2aef8
@anna-lach
Merge remote-tracking branch 'origin/main' into 'feature/1358-POC-pro…
2286bd8 
…gress-indicator-component'
@DanielleRameau
improved warning color palette SL
b8270b4
@DanielleRameau
updated warning color progress bar
9c685d8
@DanielleRameau
changed warning color progress bar
c2473f8
@anna-lach
component changes, stories, partially styling, properties and layout
4b77e1c
@DanielleRameau
added spacing token for progress bar
38a416d
@DanielleRameau
Added 1 background color token for the progress bar
3ccd426
@anna-lach
proper icons for statuses/states, stories improvements, styling chang…
08d1e69 
…es, animations
@DanielleRameau
updated spacing gaps in progress bar
1dc1a26
@anna-lach
Merge remote-tracking branch 'origin/main' into 'feature/1358-POC-pro…
3d09422 
…gress-indicator-component'
@anna-lach
Styling improvements, state instead of status, stories changes, remov…
cd5b658 
…ed unnecessary helper and default slot for helper
@anna-lach
Merge remote-tracking branch 'origin/main' into 'feature/1358-POC-pro…
ef81f61 
…gress-indicator-component'
@DanielleRameau
update
f52d525
@DanielleRameau
last update
bedfc11
@anna-lach
progress bar docs directory structure
d62b6bc
@anna-lach
component changes after new figma improvements, styles changes, parti…
983f5f1 
…ally improved accessibility
@anna-lach anna-lach linked an issue Jul 1, 2024 that may be closed by this pull request
[POC] Progress indicator #1358
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e013343

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@sl-design-system/progress-bar Patch
@sl-design-system/sanoma-learning Patch
@sl-design-system/editorial-suite Patch
@sl-design-system/my-digital-book Patch
@sl-design-system/itslearning Patch
@sl-design-system/bingel-int Patch
@sl-design-system/bingel-dc Patch
@sl-design-system/clickedu Patch
@sl-design-system/magister Patch
@sl-design-system/kampus Patch
@sl-design-system/neon Patch
@sl-design-system/teas Patch
@sl-design-system/max Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024 •
edited
Loading

🕸 Website preview

You can view a preview here (commit e0133433c255324156b198a3340250cf79ef4dcc).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024 •
edited
Loading

🕸 Storybook preview

You can view a preview here (commit e0133433c255324156b198a3340250cf79ef4dcc).

@anna-lach anna-lach marked this pull request as ready for review July 5, 2024 12:43
jpzwarte
jpzwarte approved these changes Jul 5, 2024
View reviewed changes
packages/components/progress-bar/src/progress-bar.ts Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.ts Outdated Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.ts Outdated Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.ts Outdated Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.ts Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.scss Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.scss Outdated Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.scss Outdated Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.scss Outdated Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.scss Outdated Show resolved Hide resolved
@jpzwarte
Copy link
Member

jpzwarte commented Jul 5, 2024

Please also add changesets :)

@anna-lach anna-lach marked this pull request as draft July 8, 2024 06:10
Diaan
Diaan approved these changes Jul 8, 2024
View reviewed changes
packages/components/progress-bar/src/progress-bar.ts Outdated Show resolved Hide resolved
packages/components/progress-bar/src/progress-bar.ts Outdated Show resolved Hide resolved
@anna-lach anna-lach marked this pull request as ready for review July 8, 2024 10:28
jpzwarte
jpzwarte approved these changes Jul 8, 2024
View reviewed changes
.changeset/yellow-cars-shout.md Show resolved Hide resolved
@anna-lach anna-lach merged commit 91a81b1 into main Jul 8, 2024
10 of 13 checks passed
@anna-lach anna-lach deleted the feature/1358-POC-progress-indicator-component branch July 8, 2024 11:12
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diaan Diaan Diaan approved these changes

@jpzwarte jpzwarte jpzwarte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[POC] Progress indicator
4 participants
@anna-lach @jpzwarte @Diaan @DanielleRameau