Skip to content
This repository has been archived by the owner on Aug 28, 2022. It is now read-only.

bug: parsing errors #6

Closed
thehairy opened this issue Jul 13, 2021 · 0 comments · Fixed by #7
Closed

bug: parsing errors #6

thehairy opened this issue Jul 13, 2021 · 0 comments · Fixed by #7

Comments

@thehairy
Copy link
Contributor

thehairy commented Jul 13, 2021 •
edited
Loading

Describe the bug

Parsing errors for several properties, like mass on a person.

To Reproduce

  1. Make a request for the film with ID 3
  2. Look at the great error

Expected behavior

Should return normal results
@thehairy thehairy mentioned this issue Jul 13, 2021
Merged
@favna favna closed this as completed in #7 Jul 15, 2021
favna added a commit that referenced this issue Jul 15, 2021
@thehairy @favna
fix: fixes parsing errors (#7)
f741bf4 
* fix: fixes parsing errors

Fixes several parsing errors and changes the type of episodeId to float

fix #6

* Update src/structures/Vehicle.ts

Co-authored-by: Jeroen Claassens <[email protected]>

* fix(unit tests): changed types of unit tests according to changes made before

* Update getFilm.test.ts

Co-authored-by: Jeroen Claassens <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixes parsing errors
1 participant
@thehairy