Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Azure being unable to download ip ranges #904

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Fixed Azure being unable to download ip ranges #904

merged 6 commits into from
Aug 7, 2023

Conversation

s3kim2018
Copy link
Contributor

Fixed by

  1. passing in a user agent with the URL
    Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36
  2. parsing the redirection url with regex and successfully downloading the azure ip range json file.

@s3kim2018 s3kim2018 added the bug Something isn't working label Jul 30, 2023
@s3kim2018 s3kim2018 linked an issue Jul 30, 2023 that may be closed by this pull request
Need to pass a browser user agent to automatically download ip ranges #855
Closed
@sarahwooders
Copy link
Contributor

Could you fix the black-pytype errors? You can test locally with this:

poetry run black . --line-length=140 && poetry run pytype . --config .pytype.cfg -j 16

sarahwooders
sarahwooders requested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the pytype errors have been fixed, this looks good to merge!

@sarahwooders sarahwooders merged commit 7cdc831 into skyplane-project:main Aug 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahwooders sarahwooders sarahwooders requested changes

@ShishirPatil ShishirPatil Awaiting requested review from ShishirPatil

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to pass a browser user agent to automatically download ip ranges
2 participants
@s3kim2018 @sarahwooders