Local gateway testing #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces an API for Skyplane Broadcast Todos: - [x] Fix provisioning in BroadcastDataplane - Reuse provision loop via inheritance - Move `_start_gateway` to a class method and override it - Adapt broadcast to use `bound_nodes` - [x] Add BroadcastCopyJob (ideally extend CopyJob) - [x] Update tracker to monitor broadcast jobs - [x] Add multipart support - [x] Fix dependency issue via adding dockerfile and bc_requirements - [x] Integrate with gateway and test the monitoring side Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Sarah Wooders <[email protected]>
abiswal2001
reviewed
Jun 10, 2023
Dockerfile
Outdated
There was a problem hiding this comment.
will these commented lines be needed in the future? if not can we delete for cleanliness?
There was a problem hiding this comment.
so this is needed for on-prem so I don't wanna delete it, but it makes the docker container way slower
abiswal2001
reviewed
Jun 10, 2023
abiswal2001
reviewed
Jun 10, 2023
abiswal2001
reviewed
Jun 10, 2023
|
Overall looks good to me, left a few minor comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for testing transfers locally, both for synthetic data and real object store data.