-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programmable Gateways #804
Conversation
This change introduces an API for Skyplane Broadcast Todos: - [x] Fix provisioning in BroadcastDataplane - Reuse provision loop via inheritance - Move `_start_gateway` to a class method and override it - Adapt broadcast to use `bound_nodes` - [x] Add BroadcastCopyJob (ideally extend CopyJob) - [x] Update tracker to monitor broadcast jobs - [x] Add multipart support - [x] Fix dependency issue via adding dockerfile and bc_requirements - [x] Integrate with gateway and test the monitoring side Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Sarah Wooders <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly cosmetic comments. Can we add unit test for the gateway component? It is an isolated component and it should be very easy to test standalone. This can help debugging easier as well.
I made an issue for adding gateway components tests #806, since ideally we can get this merged asap |
Changes:
Pipeline
object for queueing multiple jobs (example inpython examples/test_pipeline.py
. )Dataplane
creation to provide a topology planplanner.py
) to generate aTopologPlan
object which can be compiled into a gateway program JSON to be provided to gatewaysProgressBarTransferHook
to support tracking multiple destinations/api/v1/upload_id_maps
endpoint to Gateway API to send upload ID mappings to gateways along with chunk dispatching