Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Client in CLI uses correct transfer config #747

Merged

Conversation

zizhong
Copy link
Collaborator

@zizhong zizhong commented Feb 9, 2023

This fixes the issue that the cli uses the default transfer config.

After skyplane config set azure_instance_class DCASv5, run cp command, found the following logs.

 23:40:45 [DEBUG] User confirmed transfer
23:40:45 [INFO]  [Provisioner.add_task] Queue ProvisionerTask(cloud_provider=‘azure’, region=‘eastus’, 
vm_type=‘Standard_D2_v5’, ...)

With the fix, the logs became

00:42:14 [DEBUG] User confirmed transfer
00:42:14 [INFO]  [Provisioner.add_task] Queue ProvisionerTask(cloud_provider='azure', region='eastus', 
vm_type='DCASv5', ...)

@ShishirPatil
Copy link
Member

LGTM

@ShishirPatil ShishirPatil merged commit 77ed8fd into skyplane-project:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants