Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programmable gateways implemented with queue-only inter-process communication #678

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Programmable gateways implemented with queue-only inter-process communication #678

merged 6 commits into from
Nov 22, 2022

Conversation

sarahwooders
Copy link
Contributor

@sarahwooders sarahwooders commented Nov 15, 2022 •
edited
Loading

Remaining todos:

  • Remove ChunkRequest abstraction (only Chunk) information is needed for routing
  • Re-name ChunkStore to something more appropriate (chunk requests are no longer being managed, since all inter-process communication has been replaced with queues)
  • Migrate chunk_id to be string

@sarahwooders sarahwooders changed the title Programmable gateways implemented with queue-only inter-process communication [DRAFT] Programmable gateways implemented with queue-only inter-process communication Nov 15, 2022
@sarahwooders sarahwooders marked this pull request as draft November 15, 2022 07:03
@sarahwooders sarahwooders changed the title [DRAFT] Programmable gateways implemented with queue-only inter-process communication Programmable gateways implemented with queue-only inter-process communication Nov 15, 2022
parasj
parasj approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@parasj parasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back the gateway code and merge it!

@sarahwooders sarahwooders marked this pull request as ready for review November 22, 2022 07:29
@sarahwooders sarahwooders enabled auto-merge (squash) November 22, 2022 07:32
auto-merge was automatically disabled November 22, 2022 07:32

Pull request was closed

@sarahwooders sarahwooders reopened this Nov 22, 2022
@sarahwooders sarahwooders merged commit c483022 into main Nov 22, 2022
@sarahwooders sarahwooders deleted the broadcast-gateway branch November 22, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasj parasj parasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahwooders @parasj