Fix GCP firewall issue and increases banner timeout for SSH issue #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasj
force-pushed
the
dev/paras/fix_gcp
branch
from
739a414
to
6b3be23
Compare
parasj
changed the title
ShishirPatil
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60 by locking the firewall creation so only one process can concurrently create or update the default firewall.
Also an alternative fix for #62. Instead of catching this ConnectionReset error, the right thing to do might be to modify get_ssh_client_impl in server.py to set the following timeout for Paramiko. https://stackoverflow.com/a/59453832