Mitigate Azure object store stragglers by limiting gateway connections #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShishirPatil
reviewed
Oct 5, 2022
There was a problem hiding this comment.
Chunking is an artifact introduced by skyplane, and chunk # is not an underlying object (thought here is a 1-1 mapping). This information is critical for debugging, but is not relevant to the user. If I know there are 3 chunks remaining that might be Ok, though I don't see how that would be useful beyond informatics. The additional chunk id in-itself maybe is not so useful.
Is there any reason why you thought it would be good to print this out?
ShishirPatil
reviewed
Oct 5, 2022
|
@ShishirPatil These stats were useful for debugging stragglers, but I agree it shouldn't be user facing. I gated off that logic with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Past 24 connections, Azure blob or Azure auth begins to throttle performance. This PR sets a default limit of 24 connections for Azure.