Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky S3 test by setting default boto3 region #534

Merged
merged 3 commits into from
Sep 11, 2022
Merged

Fix flaky S3 test by setting default boto3 region #534

merged 3 commits into from
Sep 11, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Sep 11, 2022

The S3 test is flaky on main. This PR attempts to fix this test by setting the boto3 region explicitly.

@parasj parasj marked this pull request as ready for review September 11, 2022 04:39
antonzabreyko
antonzabreyko reviewed Sep 11, 2022
View reviewed changes
Copy link
Contributor

@antonzabreyko antonzabreyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@parasj parasj merged commit 0d875bd into main Sep 11, 2022
@parasj parasj deleted the fix/flaky_s3 branch September 11, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonzabreyko antonzabreyko antonzabreyko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parasj @antonzabreyko