-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Requester Pays #520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, this will really help our users! I added some minor comments to improve maintainability with a single code path for both workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Also update the error message here to note that the user may need to enable requester pays:
skyplane/skyplane/exceptions.py
Lines 7 to 11 in 0d875bd
class MissingBucketException(SkyplaneException): | |
def pretty_print_str(self): | |
err = f"[red][bold]:x: MissingBucketException:[/bold] {str(self)}[/red]" | |
err += "\n[bold][red]Please ensure that the bucket exists and is accessible.[/red][/bold]" | |
return err |
`Please ensure that the bucket exists and is accessible. See https://skyplane.org/en/latest/faq.html#i-am-unable-to-copy-files-to-a-folder-in-my-destination-bucket-due-to-a-missing-object-error.```
For that documentation page, you should add more text to elaborate on requester pays setup.
FAQ changes made in #538 |
Skyplane CLI will now take in additional flag to support requester pays bucket. Requester-pays bucket are buckets that charges the person who downloads the objects. More information in the following link: https://docs.aws.amazon.com/AmazonS3/latest/userguide/RequesterPaysBuckets.html