Fix pytype errors and minor bugs in GCP firewall #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasj
commented
Jun 27, 2022
| @@ -112,7 +112,6 @@ def azure_provisioner(r): | |||
| gcp.create_ssh_key() | |||
| gcp.configure_skyplane_network() | |||
| gcp.configure_skyplane_firewall() | |||
| do_parallel(gcp.add_ips_to_firewall, spinner=True, desc="Add IP to aws security groups") | |||
There was a problem hiding this comment.
@ShishirPatil Check this line, it seems to do nothing as written and isn't relevant yet since all instance IPs aren't known yet
parasj
commented
Jun 27, 2022
|
|
||
| elif current_firewall["allowed"] != fw_body["allowed"]: | ||
| create_firewall(fw_body, update_firewall=True) | ||
| logger.debug(f"[GCP] Updated firewall") | ||
|
|
||
| def get_vpc(self, vpc_name="skyplane"): |
There was a problem hiding this comment.
@ShishirPatil get_vpc is unused anywhere and was causing issues since make_vpc is never defined. Please double check this block carefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes some minor pytype issues from #426