Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration options for key transfer parameters #425

Merged
merged 7 commits into from
Jun 21, 2022
Merged

Add configuration options for key transfer parameters #425

merged 7 commits into from
Jun 21, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Jun 17, 2022 •
edited
Loading

This PR enables configuration of transfer behavior via a global configuration system.

Todos:

  • Integrate global configuration flags into CLI
  • Add per-transfer overrides to CLI
  • Update multipart transfer partitioning to align with new config flags

@parasj parasj self-assigned this Jun 17, 2022
@linear
Copy link

linear bot commented Jun 17, 2022

SKY-176 By default, enable multipart transfers, compression and end-to-end encryption

Note that compression and encryption are not needed for single region transfers

Configure this using skyplane config set compression true

@parasj parasj requested a review from sarahwooders June 17, 2022 22:03
parasj
parasj commented Jun 18, 2022
View reviewed changes
docs/configure.md

```{admonition} Full list of transfer options
Copy link
Contributor Author

@parasj parasj Jun 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahwooders It looks like Myst (the Markdown interpreter for Sphinx) supports most reStructuredText features!

@parasj parasj merged commit 03d0701 into main Jun 21, 2022
@parasj parasj deleted the paras/sky-176-by-default-enable-multipart-transfers branch June 21, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahwooders sarahwooders Awaiting requested review from sarahwooders

Assignees

@parasj parasj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@parasj