Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ux] catch top level exceptions with pretty printing #397 #414

Merged
merged 7 commits into from
Jun 16, 2022

Conversation

ethanmehta
Copy link
Contributor

@ethanmehta ethanmehta commented Jun 13, 2022

Fixes SKY-164
Fixes #397

@ethanmehta ethanmehta changed the title #397 [ux] catch top level exceptions with pretty printing #397 Jun 13, 2022
@ethanmehta ethanmehta requested a review from parasj June 13, 2022 22:35
@ethanmehta ethanmehta linked an issue Jun 13, 2022 that may be closed by this pull request
@parasj
Copy link
Contributor

parasj commented Jun 14, 2022

@ethanmehta to test this PR with each exception category

Copy link
Contributor

@parasj parasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to test each exception, then merge if it looks OK!

@linear
Copy link

linear bot commented Jun 14, 2022

@parasj parasj merged commit ab46a41 into main Jun 16, 2022
@parasj parasj deleted the dev/ethanmehta/exceptions_update branch June 16, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ux] Catch top level exceptions with pretty printing
2 participants