Checksum at object stores #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKY-158 Checksumming
Failure cases not covered:
|
Closed
* adding service acounts for gcp * gcp xml api for multipart uploads Co-authored-by: Paras Jain <[email protected]>
* Refactored src dest querying code into helper method * Sync design implemented * Sync bug fixed + redesign implemented * Style and typing fixes * typing issue: * Style formatting * Added TransferObjectList dataclass * Minor further refactor of TransferObjectList, add new replicate_helper_random function * Further clean up * Move TransferObjectList * Consolidate replicate_helper_cp and replicate_helper_random * Inline replicate helper Co-authored-by: Paras Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391
Fixes SKY-158
Fixes SKY-177
Implements checksums by generating a checksum object at object store download, storing it to the chunk then checking the MD5 hash at object store write-back within the destination object store.