Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #366: explicit package discovery of skyplane package #369

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Jun 1, 2022

Fixes #366 by explicitly specifying package directory in setup.py

@parasj parasj changed the title Fix #366 Fix package discovery Jun 1, 2022
@parasj parasj requested a review from milesturin June 1, 2022 20:00
@parasj parasj self-assigned this Jun 1, 2022
@parasj parasj added bug Something isn't working build labels Jun 1, 2022
@parasj parasj added this to the Bugs milestone Jun 1, 2022
@parasj
Copy link
Contributor Author

parasj commented Jun 1, 2022

@milesturin Can you test this and let me know if this fixes your build issues in #366?

@parasj parasj changed the title Fix package discovery Fix #366: package discovery of skyplane package Jun 1, 2022
@parasj parasj changed the title Fix #366: package discovery of skyplane package Fix #366: explicit package discovery of skyplane package Jun 1, 2022
@parasj parasj merged commit eeb7104 into main Jun 3, 2022
@parasj parasj deleted the dev/paras/fix_366 branch June 3, 2022 17:25
@ShishirPatil ShishirPatil restored the dev/paras/fix_366 branch June 27, 2022 06:18
@parasj parasj deleted the dev/paras/fix_366 branch June 27, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug] pip install fails due to multiple packages
1 participant