Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with GCP init due to inferred_project_id #306

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix bug with GCP init due to inferred_project_id #306

merged 1 commit into from
Apr 27, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Apr 27, 2022

Fixes #304

@parasj parasj added GCP bug Something isn't working labels Apr 27, 2022
@parasj parasj self-assigned this Apr 27, 2022
@parasj parasj added this to the Bugs milestone Apr 27, 2022
antonzabreyko
antonzabreyko approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@antonzabreyko antonzabreyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@parasj parasj merged commit 2e043a9 into main Apr 27, 2022
@parasj parasj deleted the dev/paras/fix/304 branch April 27, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonzabreyko antonzabreyko antonzabreyko approved these changes

Assignees

@parasj parasj

Labels
bug Something isn't working
Projects
No open projects
Skyplane roadmap
Status: Done
Milestone
Bugs
Development

Successfully merging this pull request may close these issues.

GCP error: skylark init complains about missing project ID
2 participants
@parasj @antonzabreyko