Fix deprovisioning bug with Azure #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkumar
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Looks good. You could probably admit some more concurrency if you want. For example, deprovisioning the NIC and IP address concurrently might work. I doubt it would save much time, though. The biggest time save may come from deprovisioning multiple instances in parallel, though I think the system already does this.
|
Yep we deprovision in parallel. I don't want to increase concurrency internally since I tried it and it added a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296 by restoring functionality to #146