Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace oslo.concurrency with ilock #294

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Replace oslo.concurrency with ilock #294

merged 4 commits into from
Apr 28, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Apr 25, 2022 •
edited
Loading

Fixes #252

This PR enables removing oslo.concurrency that added complexity to the build Dockerfile (e.g. requires gcc).

After this PR, the largest offenders of disk space include:

68M	botocore
61M	googleapiclient
37M	google
37M	azure
23M	_awscrt.cpython-310-x86_64-linux-gnu.so
14M	pip
12M	cryptography
11M	grpc
3.2M	nacl
2.9M	setuptools

@parasj parasj added the build label Apr 25, 2022
@parasj parasj self-assigned this Apr 25, 2022
@parasj parasj requested review from samkumar and removed request for antonzabreyko April 25, 2022 22:46
@parasj parasj added this to the Skylark backlog milestone Apr 27, 2022
samkumar
samkumar approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@samkumar samkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@parasj parasj merged commit a96eb05 into main Apr 28, 2022
@parasj parasj deleted the dev/paras/remove_oslo branch April 28, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samkumar samkumar samkumar approved these changes

Assignees

@parasj parasj

Labels
None yet
Projects
No open projects
Skyplane roadmap
Status: Done
Milestone
Skylark backlog
Development

Successfully merging this pull request may close these issues.

Prune pip dependency tree for gateway
2 participants
@parasj @samkumar