Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GCP re-init condition if GCP config is missing. #286

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Added GCP re-init condition if GCP config is missing. #286

merged 2 commits into from
Apr 26, 2022

Conversation

antonzabreyko
Copy link
Contributor

Fixes the issues with GCP in #278.

@antonzabreyko antonzabreyko linked an issue Apr 16, 2022 that may be closed by this pull request
skylark init should reinit each cloud if the respective config does not exist #278
Closed
@parasj parasj self-requested a review April 25, 2022 06:35
@parasj parasj added bug Something isn't working GCP labels Apr 25, 2022
parasj
parasj approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@parasj parasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@parasj parasj added this to the Bugs milestone Apr 25, 2022
@antonzabreyko antonzabreyko merged commit 0c963fa into main Apr 26, 2022
@antonzabreyko antonzabreyko deleted the reinit-cloud-config branch April 26, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasj parasj parasj approved these changes

Assignees

@antonzabreyko antonzabreyko

Labels
bug Something isn't working
Projects
No open projects
Skyplane roadmap
Status: Done
Milestone
Bugs
Development

Successfully merging this pull request may close these issues.

skylark init should reinit each cloud if the respective config does not exist
2 participants
@antonzabreyko @parasj