Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp rework 2 #284

Merged
merged 14 commits into from
Apr 16, 2022
Merged

cp rework 2 #284

merged 14 commits into from
Apr 16, 2022

Conversation

abiswal2001
Copy link
Collaborator

Couple notes fixing discrepancies between cp and how it works in linux:

  • cp will overwrite an existing file with new file contents if the dest file prefix already exists in the dest bucket, no more name concatenation (fixes Skylark cp concatenating object names when using gateways #280)
  • trailing slashes are required for directories, as is convention with s3 and in linux convention
  • trailing slashes are optional at root bucket level
  • "-r" flag was not added as by default directories are recursively copied.

@abiswal2001 abiswal2001 requested a review from parasj April 16, 2022 05:02
@abiswal2001 abiswal2001 changed the title cp rework 2 - trailing slashes now behave like linux 2 cp rework 2 Apr 16, 2022
Copy link
Contributor

@parasj parasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abiswal2001 abiswal2001 merged commit 714447f into main Apr 16, 2022
@abiswal2001 abiswal2001 deleted the dev/asim/skylark-cp-rework branch April 16, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skylark cp concatenating object names when using gateways
2 participants