Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug #237 skylark cp does not warn user if object does not exist #248

Merged
merged 12 commits into from
Apr 26, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions skylark/replicate/replicator_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ def run_replication_plan(self, job: ReplicationJob) -> ReplicationJob:
"azure",
"gcp",
], f"Only AWS, Azure, and GCP are supported, but got {job.dest_region}"
assert len(job.src_objs) > 0, f"Found {len(job.src_objs)} matching objects. Objects do not exist in src bucket or bucket is empty"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback: return errors to users by using an if statement then printing a readable error (e.g. logger.error), then raise typer.Abort()


# pre-fetch instance IPs for all gateways
gateway_ips: Dict[Server, str] = {s: s.public_ip() for s in self.bound_nodes.values()}
Expand Down