-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug #237 skylark cp does not warn user if object does not exist #248
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2fbc4a7
Fixed bug #237 skylark cp does not warn user if object does not exist
ethanmehta a12ba6e
For aws, aborts with error message and typer.abort in infer_s3_region…
ethanmehta 65ea7a9
For aws, aborts with error message and typer.abort in __init__ metho…
ethanmehta c066b3d
Bug #237, skylark now warns and aborts if object does not exist for c…
ethanmehta 0d1efa8
For a cp between a s3 bucket and local, skylark now warns and aborts …
ethanmehta efeab18
Merge branch 'main' into dev/ethanmehta/bug-warn-objects-exist
parasj 8d98701
Incorporating changes from review
ethanmehta 0a35a76
Merge branch 'dev/ethanmehta/bug-warn-objects-exist' of https://githu…
ethanmehta 96d2763
Added MissingBucketException and MissingObjectException in exceptions…
ethanmehta 5fb359a
Merge branch 'main' into dev/ethanmehta/bug-warn-objects-exist
ethanmehta f1628c9
Merge branch 'main' into dev/ethanmehta/bug-warn-objects-exist
parasj 3a99ced
Merge branch 'main' into dev/ethanmehta/bug-warn-objects-exist
ethanmehta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback: return errors to users by using an if statement then printing a readable error (e.g. logger.error), then raise typer.Abort()