Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required Python to 3.7 #223

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Update required Python to 3.7 #223

merged 2 commits into from
Mar 22, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Mar 22, 2022

Minor modifications required to support Python 3.7.

Also cleaned up Docker image.

@parasj parasj requested a review from abiswal2001 March 22, 2022 20:05
@parasj parasj self-assigned this Mar 22, 2022
@parasj parasj added the cli label Mar 22, 2022
@parasj parasj added this to the Skylark 0.1 release milestone Mar 22, 2022
@parasj parasj linked an issue Mar 22, 2022 that may be closed by this pull request
[meta] On-boarding issues with skylark #181
Closed
@abiswal2001
Copy link
Collaborator

I would just recommend updating the README requirements section to Python 3.7, other than that LGTM!

@parasj
Copy link
Contributor Author

parasj commented Mar 22, 2022

Done! Thanks Asim.

@parasj parasj merged commit 42ad665 into main Mar 22, 2022
@parasj parasj deleted the dev/paras/py37 branch March 22, 2022 20:37
parasj added a commit that referenced this pull request Mar 22, 2022
@parasj
Update required Python to 3.7 (#223)
587113a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abiswal2001 abiswal2001 Awaiting requested review from abiswal2001

Assignees

@parasj parasj

Labels
None yet
Projects
None yet
Milestone
Skylark 0.1 release
Development

Successfully merging this pull request may close these issues.

[meta] On-boarding issues with skylark
2 participants
@parasj @abiswal2001