Authentication from config #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShishirPatil
changed the title
parasj
approved these changes
Mar 2, 2022
| except Exception as e: | ||
| logger.error(f"Failed to read AWS credentials locally {e}") | ||
| # copy config file | ||
| config = config_file.read_text()[:-2] + "}" |
There was a problem hiding this comment.
What is the purpose of the substring? Can we not load it via json.loads?
There was a problem hiding this comment.
I'm concerned that the exact format of the JSON could change subtly. We should parse it and then dump it back as a string. Neat trick to use json.dumps to escape the string though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication for object stores. Azure was missing -> introduced. AWS moved to config file rather than environment variables
Solves #168
Related to #165 and #149