Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] skylark cp does not warn user if object does not exist #237

Closed
milesturin opened this issue Mar 29, 2022 · 0 comments · Fixed by #248
Closed

[bug] skylark cp does not warn user if object does not exist #237

milesturin opened this issue Mar 29, 2022 · 0 comments · Fixed by #248
Assignees
@ethanmehta
Labels
bug Something isn't working
Milestone
Bugs

Comments

@milesturin
Copy link
Contributor

It does not throw an exception, instead it prints "Downloading: 0.00B [00:00, ?B/s]". It also does not handle non-existent buckets gracefully, it just throws an exception from boto3.
@milesturin milesturin added AWS and removed AWS labels Mar 29, 2022
@parasj parasj moved this to Todo (backlog) in Skylark Alpha release Mar 30, 2022
@parasj parasj moved this from Todo (backlog) to Todo (priority) in Skylark Alpha release Mar 30, 2022
@parasj parasj changed the title skylark cp does not warn user if object does not exist [bug] skylark cp does not warn user if object does not exist Mar 31, 2022
@parasj parasj added this to the Bugs milestone Mar 31, 2022
ethanmehta added a commit that referenced this issue Apr 4, 2022
@ethanmehta
Fixed bug #237 skylark cp does not warn user if object does not exist
2fbc4a7
@ethanmehta ethanmehta moved this from Todo (priority) to Under review in Skylark Alpha release Apr 4, 2022
@ethanmehta ethanmehta added the bug Something isn't working label Apr 4, 2022
@parasj parasj mentioned this issue Apr 4, 2022
Merged
@ethanmehta ethanmehta moved this from Under review to In Progress in Skylark Alpha release Apr 6, 2022
ethanmehta added a commit that referenced this issue Apr 6, 2022
@ethanmehta
For aws, aborts with error message and typer.abort in infer_s3_region…
a12ba6e 
… method of s3_interface.py, if source bucket does not exist. bug #237
ethanmehta added a commit that referenced this issue Apr 6, 2022
@ethanmehta
For aws, aborts with error message and typer.abort in __init__ method…
65ea7a9 
… of s3_interface.py, if source bucket does not exist. bug #237
ethanmehta added a commit that referenced this issue Apr 6, 2022
@ethanmehta
Bug #237, skylark now warns and aborts if object does not exist for c…
c066b3d 
…loud to cloud with s3 source bucket
ethanmehta added a commit that referenced this issue Apr 6, 2022
@ethanmehta
For a cp between a s3 bucket and local, skylark now warns and aborts …
0d1efa8 
…if the source bucket or object do not exist, bug #237
@ethanmehta ethanmehta moved this from In Progress to Under review in Skylark Alpha release Apr 6, 2022
ethanmehta added a commit that referenced this issue Apr 26, 2022
@ethanmehta @parasj
Fixed bug #237 skylark cp does not warn user if object does not exist (…
bdea2ea 
…#248)

* Fixed bug #237 skylark cp does not warn user if object does not exist

* For aws, aborts with error message and typer.abort in infer_s3_region method of s3_interface.py, if source bucket does not exist. bug #237

* For aws, aborts with error message and typer.abort in __init__  method of s3_interface.py, if source bucket does not exist. bug #237

* Bug #237, skylark now warns and aborts if object does not exist for cloud to cloud with s3  source bucket

* For a cp between a s3 bucket and local, skylark now warns and aborts if the source  bucket or object do not exist, bug #237

* Incorporating changes from review

* Added MissingBucketException and MissingObjectException in exceptions.py. Skylark raises these instead of typer.Abort.

Co-authored-by: Paras Jain <[email protected]>
Repository owner moved this from Under review to Done in Skylark Alpha release Apr 26, 2022
@ethanmehta ethanmehta moved this to Done in Skyplane roadmap Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanmehta ethanmehta

Labels
bug Something isn't working
Projects
No open projects
Skyplane roadmap
Status: Done
Milestone
Bugs
Development

Successfully merging a pull request may close this issue.

Fixed bug #237 skylark cp does not warn user if object does not exist skyplane-project/skyplane
3 participants
@parasj @milesturin @ethanmehta