Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): Limit search to a package #2284

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

andyjsmith
Copy link
Contributor

Adds the ability to limit search to a specific package (and sub-packages).

Often, you want to search for some code inside a specific package. The only way to do this currently is to add exclusions for all the packages you don't want, perform your search, and then include the packages again.

This PR adds:

  • The ability to specify a package in the search window to limit the search to
  • A "Text search" option to the right-click menu of all packages in the tree. This opens the search with the package name pre-filled in the field.

This works for all search providers (except for resources, which just ignores the restriction if enabled).

Build passes with gradlew clean build dist

This is my first contribution here so please feel free to let me know your questions/thoughts/concerns!

Resolves #1408 and part of #818

image

image

image

@skylot
Copy link
Owner

skylot commented Sep 20, 2024

@andyjsmith great work 👍

There is one minor possible improvement: split events processing for package search/verify with triggering search. So if package change we first search matching package object and if found than trigger big search. This way package field will be interactive and will notify about incorrect package even if "auto search" is disabled. Not sure if this really needed, so I might apply these changes myself later 🙂

@skylot skylot merged commit efa2f5d into skylot:master Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] [gui] Search in specific path
2 participants