Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Compact resource entries are not supported #2268

Closed
pubiqq opened this issue Sep 6, 2024 · 4 comments
Closed

[core] Compact resource entries are not supported #2268

pubiqq opened this issue Sep 6, 2024 · 4 comments
Labels
bug Core Issues in jadx-core module resources

Comments

@pubiqq
Copy link
Contributor

pubiqq commented Sep 6, 2024

Issue details

https://cs.android.com/android/platform/superproject/+/android15-release:frameworks/base/libs/androidfw/include/androidfw/ResourceTypes.h;l=1547-1549

Jadx version

1.5.0

@pubiqq pubiqq added bug Core Issues in jadx-core module labels Sep 6, 2024
@pubiqq
Copy link
Contributor Author

pubiqq commented Sep 6, 2024

Sample here.

@skylot
Copy link
Owner

skylot commented Sep 6, 2024

Fixed. At least sample is parsed without errors now 🤣

@skylot skylot closed this as completed Sep 6, 2024
@skylot skylot removed the no-sample label Sep 6, 2024
@pubiqq
Copy link
Contributor Author

pubiqq commented Sep 6, 2024

Fixed. At least sample is parsed without errors now 🤣

Indeed, albeit not without some problems:

Screenshot

I'm going to create an issue about it on Monday, unless you fix it sooner, of course 🤣.

@skylot
Copy link
Owner

skylot commented Sep 8, 2024

@pubiqq looks like these resources have different configs but same qualifiers string, this mean we miss some new config fields. In this sample, we always skip the last 12 bytes in config data, so we need to support these new flags/fields.
I will create a new issue and implement this myself.

PR from ApkTool as a reference: iBotPeaches/Apktool#3206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module resources
Projects
None yet
Development

No branches or pull requests

2 participants