Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support detached Fragments by removing references to the Activity #613

Merged
merged 4 commits into from
Aug 22, 2024

Commits on Apr 4, 2024

  1. Use Context rather than Activity when lazy loading

    Context != Activity
    
    This should resolve issues where the fragment is not attached to an activity. We already check that the context is not null earlier in the method
    jimmithy committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    53ba4d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    354892a View commit details
    Browse the repository at this point in the history
  3. Avoid BadTokenExceptions when adding views

    An alternative approach to skydoves#92 to avoid any reference to the activity
    
    isAttachedToWindow will confirm that the anchor view has a valid window token.
    jimmithy committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7abfb9e View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Restore isFinishing to canShowBallonWindow

    Switch from a chained condition to multiple conditions that early exit.
    
    This should ensure the context doesn't have to be an activity.
    jimmithy committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    515932f View commit details
    Browse the repository at this point in the history