Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for passing touch events to the anchor #268

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

JoePaul
Copy link
Contributor

@JoePaul JoePaul commented Oct 19, 2021

Hello again,
There have been requests to add support for passing touch events to the anchor when the overlay vissible, see issue #225. This PR is supposed to do just that.

@skydoves
Copy link
Owner

Hi @JoePaul,
Everything looks good to me, but could you please run the below commands? 😄

./gradlew spotlessApply
./gradlew apiDump

Thank you for reaching out again!

@JoePaul
Copy link
Contributor Author

JoePaul commented Oct 19, 2021

Will do :)

Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for your contributuon!

@skydoves skydoves merged commit 04f2e8a into skydoves:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants