Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RibbonView changes x/y position when being recreated #4

Closed
ubuntudroid opened this issue Aug 21, 2020 · 2 comments · Fixed by #5
Closed

RibbonView changes x/y position when being recreated #4

ubuntudroid opened this issue Aug 21, 2020 · 2 comments · Fixed by #5

Comments

@ubuntudroid
Copy link
Contributor

Please complete the following information:

  • 1.0.2
  • Likely all, but tested on an Emulator with Android 11

Describe the Bug:

When using RibbonView in e.g. a RecyclerView, clicking on an item in the RecyclerView, and then returning to the RecyclerView after a few times the position of the ribbon will change.

The likely reason for this is a missing check in onLayout(changed: Boolean, ...) whether the layout actually did change. Only then the rotation code should be applied which also changes x/y values of the View.

I'll provide a PR with a fix.

Expected Behavior:

Postition of the ribbon always stays stable.
@skydoves
Copy link
Owner

HI, @ubuntudroid,
Thank you for your issue and contribution!
New PRs are always welcome. 👍

@skydoves
Copy link
Owner

Related to #3

@ubuntudroid ubuntudroid mentioned this issue Aug 21, 2020
Merged
3 tasks
skydoves added a commit that referenced this issue Aug 21, 2020
@skydoves
Merge pull request #5 from ubuntudroid/bugfix/4-fix-ribbonview-changi…
2561ecb 
…ng-position-even-if-layout-didnt-change

#4 Fix RibbonView changing position even if layout didn't change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4 Fix RibbonView changing position even if layout didn't change
2 participants
@ubuntudroid @skydoves