Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/improve health #919

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Fix/improve health #919

merged 2 commits into from
Oct 12, 2021

Conversation

alexadhy
Copy link
Contributor

Did you run make format && make check? yes

Fixes #916 (comment)

Changes:

  • Remove omitempty tag from the JSON serializer in HealthInfo struct, so false value will not be omitted.
  • Initialize health value to false first during creation of visor

How to test this PR:

@alexadhy alexadhy mentioned this pull request Oct 11, 2021
Merged
2 tasks
@jdknives jdknives merged commit 4b3aa10 into skycoin:develop Oct 12, 2021
@alexadhy alexadhy deleted the fix/improve-health branch November 23, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexadhy @jdknives