-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add build_tag to summary API endpoint #911
Conversation
I think we should print |
Good point. Added in |
pkg/visor/api.go
Outdated
} | ||
|
||
// buildTag variable that will set when building binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildTag variable set at compile time to indicate installation method of visor
may be clearer.
pkg/visor/api.go
Outdated
@@ -313,6 +320,18 @@ func (v *Visor) SkybianBuildVersion() string { | |||
return os.Getenv("SKYBIAN_BUILD_VERSION") | |||
} | |||
|
|||
// BuildTagValidation implements API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be just a helper function.
Did you run
make format && make check
?Fixes #910
Changes:
skybian
tag added for goreleaserHow to test this PR:
use
BUILDTAG=something
onmake
command. Same asmake build BUILDTAG=something