add build_tag to summary API endpoint #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should print |
Good point. Added in |
ersonp
approved these changes
Oct 7, 2021
jdknives
approved these changes
Oct 7, 2021
pkg/visor/api.go
Outdated
| } | ||
|
|
||
| // buildTag variable that will set when building binary |
There was a problem hiding this comment.
buildTag variable set at compile time to indicate installation method of visor may be clearer.
pkg/visor/api.go
Outdated
| @@ -313,6 +320,18 @@ func (v *Visor) SkybianBuildVersion() string { | |||
| return os.Getenv("SKYBIAN_BUILD_VERSION") | |||
| } | |||
|
|
|||
| // BuildTagValidation implements API. | |||
There was a problem hiding this comment.
Seems to be just a helper function.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #910
Changes:
skybiantag added for goreleaserHow to test this PR:
use
BUILDTAG=somethingonmakecommand. Same asmake build BUILDTAG=something