Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dmsgpty to skywire-cli #863

Closed
wants to merge 1 commit into from
Closed

add dmsgpty to skywire-cli #863

wants to merge 1 commit into from

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented Aug 21, 2021

add dmsgpty-cli and dmsgpty-ui comands to skywire-cli.

This PR depends on:
skycoin/dmsg#101

I've been able to test this by manually changing the dependencies to reflect the pull request in dmsg.
The dmsgpty-cli works, but the dmsgpty-ui does not register as a command, yet there are no errors or any indication why it does not appear.

The ability to launch the dmsgpty-ui from skywire-cli would be nice but is not essential for my purposes

dmsgpty-cli has been missing from skywire-cli; currently dmsgpty-ui is included with the visor.
this is a necessary step for further integration of update functionality into skywire-cli.

Changes:

  • add dmsgpty commands

How to test this PR:

skywire-cli visor dmsgpty-cli

@0pcom 0pcom changed the title add dmsgpty to skycoin-cli add dmsgpty to skywire-cli Aug 21, 2021
@0pcom 0pcom mentioned this pull request Aug 26, 2021
@jdknives
Copy link
Member

@0pcom just gave this a run and it will not work as is:

  • dmsgpty cli expects a config file to connect to the dmsgpty host
  • the dmsgpty config is not the same as the config file we use in skywire

We do not currently generate a dmsgpty config in Skywire when running a visor (or when configuring a visor). We just take various values we need from the main config in Skywire and pass them to dmsgpty.

I would not like to add support in dmsg for the Skywire config as dmsg should be independent of Skywire completely. So we should add support for it in Skywire repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants