-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stun NAT type check for sudph #825
Conversation
Looks good @ersonp . Will test and merge once we have a Stun server deployed ourselves. |
Few things are remaining such as:
|
@jdknives @i-hate-nicknames I have turned stun into a module but corrently all it's related code is in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job overall! Also I would just remove the code that you commented out. Most likely it will be gone when snet refactoring is merged, but still a good habit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, otherwise looks good.
Also, now that snet refactoring got merged there is no snet package and snet.Network entity, but the changes should fit perfectly into transport manager.
need to merge #842 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything (just a little comment) is OK. Ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good.
Please pull in |
@jdknives Currently we are not able to use |
Did you run
make format && make check
?yes
Fixes #776
Changes:
STUN
check for thesudph
transport.dmsg
andsudph
initialize separate from other modules so that the visor doesn't have to wait for them.public
field from AddTransports.How to test this PR:
./skywire-visor skywire-config.json
sudph
transport. (check the logs to see your NAT type)